git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix error in generating snapshot

From
Jakub Narebski <jnareb@gmail.com>
Date
Jul 25, 2007, 22:17 UTC
Message-ID
<11854018464134-git-send-email-jnareb@gmail.com>
In-Reply-To
<30e4a070707250627l29ce4794x97d03b8232352cae@mail.gmail.com>

There was an error while generating cmmandline to run git-archive: there were no whitespace between two options.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 0acd0ca..b381692 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4343,7 +4343,7 @@ sub git_snapshot {
 	my $cmd;
 	$filename .= "-$hash$known_snapshot_formats{$format}{'suffix'}";
 	$cmd = "$git_command archive " .
-		"--format=$known_snapshot_formats{$format}{'format'}" .
+		"--format=$known_snapshot_formats{$format}{'format'} " .
 		"--prefix=\'$name\'/ $hash";
 	if (exists $known_snapshot_formats{$format}{'compressor'}) {
 		$cmd .= ' | ' . join ' ', @{$known_snapshot_formats{$format}{'compressor'}};
-- 
1.5.2.4
Previous: Mark LevedahlNext: Junio C Hamano
Message 2 of 5 in “rc3 gitweb is broken, won't deliver snapshots”
  1. Mark LevedahlJul 25, 2007
  2. gitweb: Fix error in generating snapshotJakub Narebski, Jul 25, 2007
  3. Junio C HamanoJul 25, 2007
  4. Jakub NarebskiJul 26, 2007
  5. Junio C HamanoJul 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.