git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: make "No commits" in project list gray, not bold green

From
Matt McCutchen <hashproduct@gmail.com>
Date
Jun 28, 2007, 22:15 UTC
Message-ID
<1183068922.6108.8.camel@mattlaptop2>

A missing return statement in git_get_last_activity made gitweb think a project with no commits was in age class "age0", so the "No commits" appeared in bold green, which was ridiculous. I added the return so those projects get "noage" and added a block to gitweb.css to format the "No commits" text gray.

Signed-off-by: Matt McCutchen <hashproduct@gmail.com>
---
When I visited http://repo.or.cz/ , this bug jumped out at me!
 gitweb/gitweb.css  |    6 ++++++
 gitweb/gitweb.perl |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 7908fe3..096313b 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -281,6 +281,12 @@ table.diff_tree span.file_status.copied {
   color: #70a070;
 }
 
+/* noage: "No commits" */
+table.project_list td.noage {
+	color: #808080;
+	font-style: italic;
+}
+
 /* age2: 60*60*24*2 <= age */
 table.project_list td.age2, table.blame td.age2 {
 	font-style: italic;
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7b0e110..b251c44 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1528,6 +1528,7 @@ sub git_get_last_activity {
 		my $age = time - $timestamp;
 		return ($age, age_string($age));
 	}
+	return (undef, undef);
 }
 
 sub git_get_references {
-- 
1.5.2.2.552.gc32f
Message 1 of 1 in “gitweb: make "No commits" in project list gray, not bold green”
  1. gitweb: make "No commits" in project list gray, not bold greenMatt McCutchen, Jun 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.