[PATCH] git-send-email: RFC2822 compliant Message-ID
RFC 2822 section 3.6.4 suggests that a "good method" for generating a
Message-ID is to put the domain name of the host on the right-side of
the "@" character. Use Perl's Sys::Hostname to do the heavy lifting.
This module has been in the Perl core since version 5.
---
git-send-email.perl | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 7c0c90b..2259f4b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -21,6 +21,7 @@ use warnings;
use Term::ReadLine;
use Getopt::Long;
use Data::Dumper;
+use Sys::Hostname;
use Git;
package FakeTerm;
@@ -411,9 +412,9 @@ sub extract_valid_address {
# a random number to the end, in case we are called quicker than
# 1 second since the last time we were called.
-# We'll setup a template for the message id, using the "from" address:
-my $message_id_from = extract_valid_address($from);
-my $message_id_template = "<%s-git-send-email-$message_id_from>";
+# We'll setup a template for the message id, using the hostname:
+my $hostname = hostname();
+my $message_id_template = "<%s-git-send-email\@$hostname>";
sub make_message_id
{
--
1.5.2.2.238.g7cbf2f2
Michael Hendricks <michael@ndrix.org>