git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Avoid double-slash in path names that depend on $(sharedir).

From
Johannes Sixt <johannes.sixt@telecom.at>
Date
Jun 11, 2007, 08:02 UTC
Message-ID
<11815489372169-git-send-email-johannes.sixt@telecom.at>

Recent git-gui has the ability to determine the location of its library files relative to the --exec-dir. Its Makefile enables this capability depending on the install paths that are specified. However, without this fix there is an extra slash in a path specification, so that the Makefile does not recognize the equivalence of two paths that it compares.

A side-effect is that all "standard" builds (which do not set $(sharedir) explicitly) now exploit above mentioned gut-gui feature.

Another side-effect is that an ugly compiled-in double-slash in $(template_dir) is avoided.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index af84af9..c23031c 100644
--- a/Makefile
+++ b/Makefile
@@ -144,7 +144,7 @@ STRIP ?= strip
 prefix = $(HOME)
 bindir = $(prefix)/bin
 gitexecdir = $(bindir)
-sharedir = $(prefix)/share/
+sharedir = $(prefix)/share
 template_dir = $(sharedir)/git-core/templates/
 ifeq ($(prefix),/usr)
 sysconfdir = /etc
-- 
1.5.2.1.120.gd732
Next: Junio C Hamano
Message 1 of 3 in “Avoid double-slash in path names that depend on $(sharedir).”
  1. Avoid double-slash in path names that depend on $(sharedir).Johannes Sixt, Jun 11, 2007
  2. Junio C HamanoJun 11, 2007
  3. Johannes SixtJun 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.