git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] rev-parse: Identify short sha1 sums correctly.

From
James Bowes <jbowes@dangerouslyinc.com>
Date
May 29, 2007, 23:29 UTC
Message-ID
<1180481391179-git-send-email-jbowes@dangerouslyinc.com>

find_short_packed_object was not loading the pack index files. Teach it to do so.

Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
---
 sha1_name.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index 8dfceb2..7df01af 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -76,8 +76,11 @@ static int find_short_packed_object(int len, const unsigned char *match, unsigne
 
 	prepare_packed_git();
 	for (p = packed_git; p && found < 2; p = p->next) {
-		uint32_t num = p->num_objects;
-		uint32_t first = 0, last = num;
+		uint32_t num, last;
+		uint32_t first = 0;
+		open_pack_index(p);
+		num = p->num_objects;
+		last = num;
 		while (first < last) {
 			uint32_t mid = (first + last) / 2;
 			const unsigned char *now;
-- 
1.5.2.869.g6b3ba
Next: Junio C Hamano
Message 1 of 3 in “rev-parse: Identify short sha1 sums correctly.”
  1. rev-parse: Identify short sha1 sums correctly.James Bowes, May 29, 2007
  2. Junio C HamanoMay 30, 2007
  3. James BowesMay 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.