git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] builtin-shortlog.c: Use for_each_revision() helper

From
LCLuiz Fernando N Capitulino <lcapitulino@mandriva.com.br>
Date
Apr 26, 2007, 19:46 UTC
Message-ID
<11776168011384-git-send-email-lcapitulino@mandriva.com.br>
In-Reply-To
<11776168001253-git-send-email-lcapitulino@mandriva.com.br>
Signed-off-by: Luiz Fernando N Capitulino <lcapitulino@mandriva.com.br>
---
 builtin-shortlog.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/builtin-shortlog.c b/builtin-shortlog.c
index 3f93498..eca802d 100644
--- a/builtin-shortlog.c
+++ b/builtin-shortlog.c
@@ -216,8 +216,7 @@ static void get_from_rev(struct rev_info *rev, struct path_list *list)
 	char scratch[1024];
 	struct commit *commit;
 
-	prepare_revision_walk(rev);
-	while ((commit = get_revision(rev)) != NULL) {
+	for_each_revision(commit, rev) {
 		const char *author = NULL, *oneline, *buffer;
 		int authorlen = authorlen, onelinelen;
 
-- 
1.5.1.1.320.g1cf2
Previous: Luiz Fernando N CapitulinoNext: Luiz Fernando N Capitulino
Message 7 of 15 in “RFC: for_each_revision() helper”
  1. 0/5 RFC: for_each_revision() helperLuiz Fernando N Capitulino, Apr 26, 2007
  2. 1/5 Introduces for_each_revision() helperLuiz Fernando N Capitulino, Apr 26, 2007
  3. Andy WhitcroftApr 26, 2007
  4. Luiz Fernando N. CapitulinoApr 26, 2007
  5. 2/5 builtin-fmt-merge-msg.c: Use for_each_revision() helperLuiz Fernando N Capitulino, Apr 26, 2007
  6. 3/5 reachable.c: Use for_each_revision() helperLuiz Fernando N Capitulino, Apr 26, 2007
  7. 4/5 builtin-shortlog.c: Use for_each_revision() helperLuiz Fernando N Capitulino, Apr 26, 2007
  8. 5/5 builtin-log.c: Use for_each_revision() helperLuiz Fernando N Capitulino, Apr 26, 2007
  9. Hermes TrismegistoApr 26, 2007
  10. Sam RavnborgApr 26, 2007
  11. Luiz Fernando N. CapitulinoApr 26, 2007
  12. Luiz Fernando N. CapitulinoApr 26, 2007
  13. Junio C HamanoApr 26, 2007
  14. Luiz Fernando N. CapitulinoApr 27, 2007
  15. Junio C HamanoApr 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.