[PATCH 6/9] Validate @recipients before using it for sendmail and Net::SMTP.
- From
Robin H. Johnson <robbat2@gentoo.org>
- Date
- Apr 26, 2007, 02:37 UTC
- Message-ID
- <11775550433329-git-send-email-robbat2@gentoo.org>
- In-Reply-To
- <11775550432746-git-send-email-robbat2@gentoo.org>
From: Robin H. Johnson <robbat2@gentoo.org>
Ensure that @recipients is only raw addresses when it is handed to the sendmail binary OR Net::SMTP, otherwise BCC cases might get an extra <, or wierd stuff might be passed to the exec.
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> --- git-send-email.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index c052760..0e1cc16 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -449,6 +449,7 @@ sub send_message @cc = (map { sanitize_address_rfc822($_) } @cc); my $to = join (",\n\t", @recipients); @recipients = unique_email_list(@recipients,@cc,@bcclist); + @recipients = (map { extract_valid_address($_) } @recipients); my $date = format_2822_time($time++); my $gitversion = '@@GIT_VERSION@@'; if ($gitversion =~ m/..GIT_VERSION../) { @@ -477,7 +478,7 @@ X-Mailer: git-send-email $gitversion $header .= join("\n", @xh) . "\n"; } - my @sendmail_parameters = ('-i', map { extract_valid_address($_) } @recipients); + my @sendmail_parameters = ('-i', @recipients); if ($dry_run) { # We don't want to send the email.
-- 1.5.2.rc0.43.g2f4c7