git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: Ignore usernames in URLs in find_by_url

From
Adam Roben <aroben@apple.com>
Date
Apr 25, 2007, 19:42 UTC
Message-ID
<1177530178545-git-send-email-aroben@apple.com>

Usernames don't matter for the purposes of find_by_url, so always remove them before doing any comparisons.

Signed-off-by: Adam Roben <aroben@apple.com>
---
 git-svn.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 90f3bc1..59008cc 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1064,6 +1064,8 @@ sub init_remote_config {
 
 sub find_by_url { # repos_root and, path are optional
 	my ($class, $full_url, $repos_root, $path) = @_;
+	remove_username($full_url);
+	remove_username($repos_root) if defined $repos_root;
 	return undef unless defined $full_url;
 	my $remotes = read_all_remotes();
 	if (defined $full_url && defined $repos_root && !defined $path) {
@@ -1072,6 +1074,7 @@ sub find_by_url { # repos_root and, path are optional
 	}
 	foreach my $repo_id (keys %$remotes) {
 		my $u = $remotes->{$repo_id}->{url} or next;
+		remove_username($u);
 		next if defined $repos_root && $repos_root ne $u;
 
 		my $fetch = $remotes->{$repo_id}->{fetch} || {};
-- 
1.5.2.rc0.16.ge10ca-dirty
Next: Eric Wong
Message 1 of 2 in “git-svn: Ignore usernames in URLs in find_by_url”
  1. git-svn: Ignore usernames in URLs in find_by_urlAdam Roben, Apr 25, 2007
  2. Eric WongApr 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.