git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] send-email: do not leave an empty CC: line if no cc is present.

From
Junio C Hamano <junkio@cox.net>
Date
Apr 17, 2007, 04:43 UTC
Message-ID
<11767850012084-git-send-email-junkio@cox.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 * I've almost never used send-email myself, but I decided that
   I should eat somebody's dog food I inherited.  Once I got
   annoyed enough, I may end up rewriting large portions of it,
   perhaps.
 git-send-email.perl |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 1278fcb..d6b1548 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -446,9 +446,12 @@ sub send_message
 		my ($name, $addr) = ($from =~ /^(.*?)(\s+<.*)/);
 		$from = "\"$name\"$addr";
 	}
+	my $ccline = "";
+	if ($cc ne '') {
+		$ccline = "\nCc: $cc";
+	}
 	my $header = "From: $from
-To: $to
-Cc: $cc
+To: $to${ccline}
 Subject: $subject
 Date: $date
 Message-Id: $message_id
-- 
1.5.1.1.821.g88bdb
Message 1 of 1 in “send-email: do not leave an empty CC: line if no cc is present.”
  1. send-email: do not leave an empty CC: line if no cc is present.Junio C Hamano, Apr 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.