git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-quiltimport /bin/sh-ism fix

From
WBWu, Bryan <bryan.wu@analog.com>
Date
Mar 30, 2007, 02:05 UTC
Message-ID
<1175220304.15391.46.camel@roc-desktop>
In-Reply-To
<20070329213820.GY24561@craic.sysops.org>
On Thu, 2007-03-29 at 22:38 +0100, Francis Daly wrote:
Show 27 quoted lines
> Bryan Wu reported
> /usr/local/bin/git-quiltimport: 114: Syntax error: Missing '))'
> 
> Most bourne-ish shells I have here accept
>  x=$((echo x)|cat)
> but all bourne-ish shells I have here accept
>  x=$( (echo x)|cat)
> because $(( might mean arithmetic expansion.
> 
> Signed-off-by: Francis Daly <francis@daoine.org>
> ---
>  git-quiltimport.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-quiltimport.sh b/git-quiltimport.sh
> index 08ac9bb..edccd82 100755
> --- a/git-quiltimport.sh
> +++ b/git-quiltimport.sh
> @@ -115,7 +115,7 @@ for patch_name in $(cat "$QUILT_PATCHES/series" | grep -v '^#'); do
>  	if [ -z "$dry_run" ] ; then
>  		git-apply --index -C1 "$tmp_patch" &&
>  		tree=$(git-write-tree) &&
> -		commit=$((echo "$SUBJECT"; echo; cat "$tmp_msg") | git-commit-tree $tree -p $commit) &&
> +		commit=$( (echo "$SUBJECT"; echo; cat "$tmp_msg") | git-commit-tree $tree -p $commit) &&
>  		git-update-ref -m "quiltimport: $patch_name" HEAD $commit || exit 4
>  	fi
>  done

Cool. Thanks a lot. -Bryan

Previous: Junio C Hamano
Message 3 of 3 in “git-quiltimport /bin/sh-ism fix”
  1. git-quiltimport /bin/sh-ism fixFrancis Daly, Mar 29, 2007
  2. Junio C HamanoMar 29, 2007
  3. Wu, BryanMar 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.