git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix type confusion in pkt-line

From
Rrogan@dawes.za.net <rogan@dawes.za.net>
Date
Mar 27, 2007, 10:54 UTC
Message-ID
<1174992847659-git-send-email-rogan@dawes.za.net>
From: Rogan Dawes <rogan@dawes.za.net>

We were using unsigend and signed int when we should have been using size_t and ssize_t.

Signed-off-by: Rogan Dawes <rogan@dawes.za.net>
---
 pkt-line.c |   10 +++++-----
 pkt-line.h |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/pkt-line.c b/pkt-line.c
index b4cb7e2..559a944 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -63,12 +63,12 @@ void packet_write(int fd, const char *fmt, ...)
 	safe_write(fd, buffer, n);
 }
 
-static void safe_read(int fd, void *buffer, unsigned size)
+static void safe_read(int fd, void *buffer, size_t size)
 {
-	int n = 0;
+	size_t n = 0;
 
 	while (n < size) {
-		int ret = xread(fd, (char *) buffer + n, size - n);
+		ssize_t ret = xread(fd, (char *) buffer + n, size - n);
 		if (ret < 0)
 			die("read error (%s)", strerror(errno));
 		if (!ret)
@@ -77,10 +77,10 @@ static void safe_read(int fd, void *buffer, unsigned size)
 	}
 }
 
-int packet_read_line(int fd, char *buffer, unsigned size)
+ssize_t packet_read_line(int fd, char *buffer, size_t size)
 {
 	int n;
-	unsigned len;
+	size_t len;
 	char linelen[4];
 
 	safe_read(fd, linelen, 4);
diff --git a/pkt-line.h b/pkt-line.h
index 9df653f..073fcd4 100644
--- a/pkt-line.h
+++ b/pkt-line.h
@@ -9,7 +9,7 @@
 void packet_flush(int fd);
 void packet_write(int fd, const char *fmt, ...) __attribute__((format (printf, 2, 3)));
 
-int packet_read_line(int fd, char *buffer, unsigned size);
+ssize_t packet_read_line(int fd, char *buffer, size_t size);
 ssize_t safe_write(int, const void *, ssize_t);
 
 #endif
-- 
1.5.0.3
Message 1 of 1 in “Fix type confusion in pkt-line”
  1. Fix type confusion in pkt-linerogan@dawes.za.net, Mar 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.