git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Replace remaining instances of strdup with xstrdup.

From
James Bowes <jbowes@dangerouslyinc.com>
Date
Mar 19, 2007, 21:42 UTC
Message-ID
<1174340560341-git-send-email-jbowes@dangerouslyinc.com>
Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
---

This is a blatant copy of Shawn's patch. I don't know if there's a reason these are still strdup. If there is, please ignore this patch :)

 builtin-log.c |    2 +-
 commit.c      |    2 +-
 revision.c    |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 865832c..71df957 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -35,7 +35,7 @@ static void cmd_log_init(int argc, const char **argv, const char *prefix,
 		if (!prefixcmp(arg, "--encoding=")) {
 			arg += 11;
 			if (strcmp(arg, "none"))
-				git_log_output_encoding = strdup(arg);
+				git_log_output_encoding = xstrdup(arg);
 			else
 				git_log_output_encoding = "";
 		}
diff --git a/commit.c b/commit.c
index 5b9234e..718e568 100644
--- a/commit.c
+++ b/commit.c
@@ -706,7 +706,7 @@ static char *logmsg_reencode(const struct commit *commit,
 	encoding = get_header(commit, "encoding");
 	use_encoding = encoding ? encoding : utf8;
 	if (!strcmp(use_encoding, output_encoding))
-		out = strdup(commit->buffer);
+		out = xstrdup(commit->buffer);
 	else
 		out = reencode_string(commit->buffer,
 				      output_encoding, use_encoding);
diff --git a/revision.c b/revision.c
index bcdb6a1..c680dcb 100644
--- a/revision.c
+++ b/revision.c
@@ -1038,7 +1038,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
 			if (!prefixcmp(arg, "--encoding=")) {
 				arg += 11;
 				if (strcmp(arg, "none"))
-					git_log_output_encoding = strdup(arg);
+					git_log_output_encoding = xstrdup(arg);
 				else
 					git_log_output_encoding = "";
 				continue;
-- 
1.5.1.rc1.1.g504b
Message 1 of 1 in “Replace remaining instances of strdup with xstrdup.”
  1. Replace remaining instances of strdup with xstrdup.James Bowes, Mar 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.