git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/8] gitweb: Change log action to use parse_commits.

From
RFRobert Fitzsimons <robfitz@273k.net>
Date
Dec 24, 2006, 14:31 UTC
Message-ID
<11669707101872-git-send-email-robfitz@273k.net>
In-Reply-To
<11669707102678-git-send-email-robfitz@273k.net>
Also add missing next link to bottom of page.
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---
 gitweb/gitweb.perl |   25 ++++++++++++++-----------
 1 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 5f1ace9..42b7449 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3645,28 +3645,25 @@ sub git_log {
 	}
 	my $refs = git_get_references();
 
-	my $limit = sprintf("--max-count=%i", (100 * ($page+1)));
-	open my $fd, "-|", git_cmd(), "rev-list", $limit, $hash, "--"
-		or die_error(undef, "Open git-rev-list failed");
-	my @revlist = map { chomp; $_ } <$fd>;
-	close $fd;
+	my @commitlist = parse_commits($hash, 101, (100 * $page));
 
-	my $paging_nav = format_paging_nav('log', $hash, $head, $page, $#revlist);
+	my $paging_nav = format_paging_nav('log', $hash, $head, $page, (100 * ($page+1)));
 
 	git_header_html();
 	git_print_page_nav('log','', $hash,undef,undef, $paging_nav);
 
-	if (!@revlist) {
+	if (!@commitlist) {
 		my %co = parse_commit($hash);
 
 		git_print_header_div('summary', $project);
 		print "<div class=\"page_body\"> Last change $co{'age_string'}.<br/><br/></div>\n";
 	}
-	for (my $i = ($page * 100); $i <= $#revlist; $i++) {
-		my $commit = $revlist[$i];
-		my $ref = format_ref_marker($refs, $commit);
-		my %co = parse_commit($commit);
+	my $to = ($#commitlist >= 99) ? (99) : ($#commitlist);
+	for (my $i = 0; $i <= $to; $i++) {
+		my %co = %{$commitlist[$i]};
 		next if !%co;
+		my $commit = $co{'id'};
+		my $ref = format_ref_marker($refs, $commit);
 		my %ad = parse_date($co{'author_epoch'});
 		git_print_header_div('commit',
 		               "<span class=\"age\">$co{'age_string'}</span>" .
@@ -3688,6 +3685,12 @@ sub git_log {
 		git_print_log($co{'comment'}, -final_empty_line=> 1);
 		print "</div>\n";
 	}
+	if ($#commitlist >= 100) {
+		print "<div class=\"page_nav\">\n";
+		print $cgi->a({-href => href(action=>"log", hash=>$hash, page=>$page+1),
+			       -accesskey => "n", -title => "Alt-n"}, "next");
+		print "</div>\n";
+	}
 	git_footer_html();
 }
 
-- 
1.4.4.3.ge655-dirty
Previous: Robert FitzsimonsNext: Robert Fitzsimons
Message 4 of 10 in “gitweb: Add parse_commits, used to bulk load commit objects.”
  1. 1/8 gitweb: Add parse_commits, used to bulk load commit objects.Robert Fitzsimons, Dec 24, 2006
  2. 2/8 gitweb: We do longer need the --parents flag in rev-list.Robert Fitzsimons, Dec 24, 2006
  3. 3/8 gitweb: Change summary, shortlog actions to use parse_commits.Robert Fitzsimons, Dec 24, 2006
  4. 4/8 gitweb: Change log action to use parse_commits.Robert Fitzsimons, Dec 24, 2006
  5. 5/8 gitweb: Change header search action to use parse_commits.Robert Fitzsimons, Dec 24, 2006
  6. 6/8 gitweb: Change atom, rss actions to use parse_commits.Robert Fitzsimons, Dec 24, 2006
  7. 7/8 gitweb: Change history action to use parse_commits.Robert Fitzsimons, Dec 24, 2006
  8. 8/8 gitweb: Use rev-list --skip option.Robert Fitzsimons, Dec 24, 2006
  9. Jakub NarebskiDec 25, 2006
  10. gitweb: Re-enable rev-list --parents for parse_commit.Robert Fitzsimons, Dec 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.