git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] gitweb: Add an option to href() to return full URL

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 18, 2006, 22:35 UTC
Message-ID
<1163889347230-git-send-email-jnareb@gmail.com>
In-Reply-To
<1163889342877-git-send-email-jnareb@gmail.com>

href subroutine by default generates absolute URL (generated using CGI::url(-absolute=>1), and saved in $my_uri) using $my_uri as base; add an option to generate full URL using $my_url as base.

New feature usage: href(..., -full=>1)

To be used in web feeds (RSS, Atom, OPML) and other places which need full URL rather than absolute or relative.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 5875ba0..8739501 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -459,7 +459,8 @@ exit;
 
 sub href(%) {
 	my %params = @_;
-	my $href = $my_uri;
+	# default is to use -absolute url() i.e. $my_uri
+	my $href = $params{-full} ? $my_url : $my_uri;
 
 	# XXX: Warning: If you touch this, check the search form for updating,
 	# too.
-- 
1.4.3.4
Previous: Jakub Narebski
Message 7 of 7 in “gitweb: New patchset view corrections and improvements, and few other things”
  1. 0/5 gitweb: New patchset view corrections and improvements, and few other thingsJakub Narebski, Nov 18, 2006
  2. 1/5 gitweb: Protect against possible warning in git_commitdiffJakub Narebski, Nov 18, 2006
  3. Jakub NarebskiNov 18, 2006
  4. 2/5 gitweb: Buffer diff header to deal with split patches + git_patchset_body refactoringJakub Narebski, Nov 18, 2006
  5. 3/5 gitweb: New improved formatting of chunk header in diffJakub Narebski, Nov 18, 2006
  6. 4/5 gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff"Jakub Narebski, Nov 18, 2006
  7. 5/5 gitweb: Add an option to href() to return full URLJakub Narebski, Nov 18, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.