git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: split the path from the url correctly with limited perms

From
EWEric Wong <normalperson@yhbt.net>
Date
Aug 11, 2006, 18:11 UTC
Message-ID
<11553198891741-git-send-email-normalperson@yhbt.net>

This version of the splitter (that only affects SVN:: library users) works when one only has limited read-permissions to the repository they're fetching from.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-svn.perl |   25 +++++++++++--------------
 1 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 6453771..a033237 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1160,27 +1160,24 @@ sub repo_path_split {
 		}
 	}
 
-	my ($url, $path) = ($full_url =~ m!^([a-z\+]+://[^/]*)(.*)$!i);
-	$path =~ s#^/+##;
-	my @paths = split(m#/+#, $path);
-
 	if ($_use_lib) {
-		while (1) {
-			$SVN = libsvn_connect($url);
-			last if (defined $SVN &&
-				defined eval { $SVN->get_latest_revnum });
-			my $n = shift @paths || last;
-			$url .= "/$n";
-		}
+		$SVN = libsvn_connect($full_url);
+		my $url = $SVN->get_repos_root;
+		$full_url =~ s#^\Q$url\E/*##;
+		push @repo_path_split_cache, qr/^(\Q$url\E)/;
+		return ($url, $full_url);
 	} else {
+		my ($url, $path) = ($full_url =~ m!^([a-z\+]+://[^/]*)(.*)$!i);
+		$path =~ s#^/+##;
+		my @paths = split(m#/+#, $path);
 		while (quiet_run(qw/svn ls --non-interactive/, $url)) {
 			my $n = shift @paths || last;
 			$url .= "/$n";
 		}
+		push @repo_path_split_cache, qr/^(\Q$url\E)/;
+		$path = join('/',@paths);
+		return ($url, $path);
 	}
-	push @repo_path_split_cache, qr/^(\Q$url\E)/;
-	$path = join('/',@paths);
-	return ($url, $path);
 }
 
 sub setup_git_svn {
-- 
1.4.2.rc1.g018f
Next: Eric Wong
Message 1 of 4 in “git-svn: split the path from the url correctly with limited perms”
  1. git-svn: split the path from the url correctly with limited permsEric Wong, Aug 11, 2006
  2. git-svn: bugfix: allow SVN:: lib users to track the root of the repositoryEric Wong, Aug 11, 2006
  3. Junio C HamanoAug 11, 2006
  4. git-svn: split the path from the url correctly with limited permsEric Wong, Aug 12, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.