Re: [PATCH] Remove more gcc extension usage.

From: Pavel Roskin <proski@gnu.org>
Date: Jul 10, 2006, 06:22 UTC
Message-ID: <1152512523.3504.28.camel@dv>
In-Reply-To: <20060710052255.GA15173@spearce.org>

Hi, Shawn!

On Mon, 2006-07-10 at 01:22 -0400, Shawn Pearce wrote:

Show 7 quoted lines

>   $ cc -V                                                        
>   cc: Forte Developer 7 C 5.4 2002/03/09
>   usage: cc [ options] files.  Use 'cc -flags' for details
> 
> and from `man cc`:
> 
>   -xc99  enables C99 features:

[skip]

>           o  Flexible Array Members

This must be enabled already because it's used in git (see FLEX_ARRAY).

> So neither of the constructs my patch removes are supported in this
> (old) compiler, although a newer one might accept them with -xc99.
> Yes, I tried building a pristine git-1.4.1 with -xc99.  It barfed,
> as one would expect given the description above.

This means that the Sun compiler has almost all c99 features used by git with just a little exception (initializers). I think it's fair that we fix this incompatibility. It's very very minor compared to what "gcc -std=c89 -pedantic" would have required.

-- 
Regards,
Pavel Roskin