git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] git-svn: tests no longer fail if LC_ALL is not a UTF-8 locale

From
EWEric Wong <normalperson@yhbt.net>
Date
Jun 16, 2006, 17:57 UTC
Message-ID
<11504806481800-git-send-email-normalperson@yhbt.net>
In-Reply-To
<11504806472857-git-send-email-normalperson@yhbt.net>
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 contrib/git-svn/Makefile                   |    5 +++--
 contrib/git-svn/t/t0000-contrib-git-svn.sh |    8 ++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/contrib/git-svn/Makefile b/contrib/git-svn/Makefile
index d73aa56..6aedb10 100644
--- a/contrib/git-svn/Makefile
+++ b/contrib/git-svn/Makefile
@@ -32,9 +32,10 @@ test: git-svn
 	cd t && $(SHELL) ./t0000-contrib-git-svn.sh $(TEST_FLAGS)
 	cd t && $(SHELL) ./t0001-contrib-git-svn-props.sh $(TEST_FLAGS)
 
+# we can test NO_OPTIMIZE_COMMITS independently of LC_ALL
 full-test:
-	$(MAKE) test GIT_SVN_NO_LIB=1 GIT_SVN_NO_OPTIMIZE_COMMITS=1
-	$(MAKE) test GIT_SVN_NO_LIB=0 GIT_SVN_NO_OPTIMIZE_COMMITS=1
+	$(MAKE) test GIT_SVN_NO_LIB=1 GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
+	$(MAKE) test GIT_SVN_NO_LIB=0 GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
 	$(MAKE) test GIT_SVN_NO_LIB=1 GIT_SVN_NO_OPTIMIZE_COMMITS=0 \
 							LC_ALL=en_US.UTF-8
 	$(MAKE) test GIT_SVN_NO_LIB=0 GIT_SVN_NO_OPTIMIZE_COMMITS=0 \
diff --git a/contrib/git-svn/t/t0000-contrib-git-svn.sh b/contrib/git-svn/t/t0000-contrib-git-svn.sh
index f896e2c..0f52746 100644
--- a/contrib/git-svn/t/t0000-contrib-git-svn.sh
+++ b/contrib/git-svn/t/t0000-contrib-git-svn.sh
@@ -194,8 +194,12 @@ test_expect_success "$name" \
      diff -u a b"
 
 name='check imported tree checksums expected tree checksums'
-cat > expected <<\EOF
-tree f735671b89a7eb30cab1d8597de35bd4271ab813
+rm -f expected
+if test -n "$GIT_SVN_LC_ALL" && echo $GIT_SVN_LC_ALL | grep -q '\.UTF-8$'
+then
+	echo tree f735671b89a7eb30cab1d8597de35bd4271ab813 > expected
+fi
+cat >> expected <<\EOF
 tree 4b9af72bb861eaed053854ec502cf7df72618f0f
 tree 031b8d557afc6fea52894eaebb45bec52f1ba6d1
 tree 0b094cbff17168f24c302e297f55bfac65eb8bd3
-- 
1.4.0
Previous: Eric WongNext: Eric Wong
Message 6 of 8 in “git-svn: avoid creating some small files”
  1. 1/3 git-svn: avoid creating some small filesEric Wong, Jun 15, 2006
  2. 2/3 git-svn: fix several small bugs, enable branch optimizationEric Wong, Jun 15, 2006
  3. 3/3 git-svn: Eliminate temp file usage in libsvn_get_file()Eric Wong, Jun 15, 2006
  4. 0/4 git-svn: more improvementsEric Wong, Jun 16, 2006
  5. 1/4 git-svn: bugfix and optimize the 'log' commandEric Wong, Jun 16, 2006
  6. 2/4 git-svn: tests no longer fail if LC_ALL is not a UTF-8 localeEric Wong, Jun 16, 2006
  7. 3/4 git-svn: svn (command-line) 1.0.x compatibilityEric Wong, Jun 16, 2006
  8. 4/4 git-svn: rebuild convenience and bugfixesEric Wong, Jun 16, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.