git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: remove assertion that broke with older versions of svn

From
EWEric Wong <normalperson@yhbt.net>
Date
May 30, 2006, 02:03 UTC
Message-ID
<1148954626357-git-send-email-normalperson@yhbt.net>
In-Reply-To
<20060529063543.GA8128@localdomain>

svn < 1.3.x would display changes to keywords lines as modified if they aren't expanded in the working copy. We already check for changes against the git tree here, so checking against the svn one is probably excessive.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 contrib/git-svn/git-svn.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
b430de64cb228512b9a817499203827c0ef645aa
diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl
index b3e0684..aac8779 100755
--- a/contrib/git-svn/git-svn.perl
+++ b/contrib/git-svn/git-svn.perl
@@ -567,7 +567,6 @@ sub precommit_check {
 sub svn_checkout_tree {
 	my ($svn_rev, $treeish) = @_;
 	my $from = file_to_s("$REV_DIR/$svn_rev");
-	assert_svn_wc_clean($svn_rev);
 	assert_tree($from);
 	print "diff-tree $from $treeish\n";
 	my $pid = open my $diff_fh, '-|';
-- 
1.3.2.g7d11
Previous: Eric Wong
Message 9 of 9 in “Tried to fix git-svn's handling of filenames with embedded '@'.”
  1. 0/1 Tried to fix git-svn's handling of filenames with embedded '@'.Seth Falcon, May 28, 2006
  2. 1/1 Tried to fix git-svn's handling of filenames with embedded '@'.Seth Falcon, May 28, 2006
  3. Junio C HamanoMay 28, 2006
  4. Eric WongMay 29, 2006
  5. Eric WongMay 29, 2006
  6. Seth FalconMay 29, 2006
  7. git-svn: compat fixes for older svn and dashEric Wong, May 30, 2006
  8. git-svn: t0001: workaround a heredoc bug in old versions of dashEric Wong, May 30, 2006
  9. git-svn: remove assertion that broke with older versions of svnEric Wong, May 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.