git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] cvsimport: replace anonymous sub ref with a normal sub

From
MLMartin Langhoff <martin@catalyst.net.nz>
Date
May 22, 2006, 12:45 UTC
Message-ID
<11483019392683-git-send-email-martin@catalyst.net.nz>
commit() does not need to be an anonymous subreference. Keep it simple.
Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 git-cvsimport.perl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
a0bbc1c2010ca46fc215453d5e4c4853c679f950
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index c1923d1..2ecfe14 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -563,7 +563,7 @@ my $state = 0;
 
 my($patchset,$date,$author_name,$author_email,$branch,$ancestor,$tag,$logmsg);
 my(@old,@new,@skipped);
-my $commit = sub {
+sub commit {
 	my $pid;
 	while(@old) {
 		my @o2;
@@ -853,7 +853,7 @@ #	VERSION:1.96->1.96.2.1
 		if ($opt_L && $commitcount++ >= $opt_L) {
 			last;
 		}
-		&$commit();
+		commit();
 		$state = 1;
 	} elsif($state == 11 and /^-+$/) {
 		$state = 1;
@@ -863,7 +863,7 @@ #	VERSION:1.96->1.96.2.1
 		print "* UNKNOWN LINE * $_\n";
 	}
 }
-&$commit() if $branch and $state != 11;
+commit() if $branch and $state != 11;
 
 unlink($git_index);
 
-- 
1.3.2.g82000
Message 1 of 1 in “cvsimport: replace anonymous sub ref with a normal sub”
  1. cvsimport: replace anonymous sub ref with a normal subMartin Langhoff, May 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.