Re: git-feed-mail-list.sh

From: David Woodhouse <dwmw2@infradead.org>
Date: May 9, 2006, 00:28 UTC
Message-ID: <1147134522.2694.45.camel@shinybook.infradead.org>
In-Reply-To: <Pine.LNX.4.64.0605081715270.3718@g5.osdl.org>

On Mon, 2006-05-08 at 17:19 -0700, Linus Torvalds wrote:

Show 11 quoted lines

> Well, you might choose to just not use "git-cat-file commit" but instead 
> ask git to format the thing for you.
> 
> Ie you could probably more easily parse the data from something like
> 
> 	git show -B --patch-with-stat --pretty=fuller $commit
> 
> instead of using "git-cat-file commit $commit" and generating the stat and 
> diff manually.
> 
> That way you get the dates etc pretty-printed for you by git.

Aha, thanks. Git has learned to do a lot more since I first started hacking up a copy of git-log.sh to feed the mailing lists, and it even had to walk the commit tree manually :)

The output of (the undocumented) '--pretty=fuller' is probably good enough that I can just feed the mailing list with it directly. I think I have to add the commit and the parent manually, but that's easy enough to do -- the commit is obviously known, and the parent is just $(git-rev-parse $commit^1).

Anyone got any objections to switching the kernel git-commits-* lists to this format?

-- 
dwmw2