[PATCH] cvsserver: use git-rev-list instead of git-log

From

MLMartin Langhoff <martin@catalyst.net.nz>

Date

May 3, 2006, 22:53 UTC

Message-ID

<11466968173651-git-send-email-martin@catalyst.net.nz>

In-Reply-To

<Pine.LNX.4.64.0605030745550.4086@g5.osdl.org>

On 5/4/06, Linus Torvalds <torvalds@osdl.org> wrote:

> No it wasn't. "git log --parents" was definitely supposed to still work.
>
> That said, I suspect a git-cvsserver kind of usage is better off using
> "git-rev-list --parents HEAD" instead, which didn't break in the first
> place.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>

---

 git-cvsserver.perl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

a248c9614fdd130229fb5f9565abbd77bd1d0cc9

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 11d153c..ffd9c66 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -2076,14 +2076,15 @@ sub update
     # TODO: log processing is memory bound
     # if we can parse into a 2nd file that is in reverse order
     # we can probably do something really efficient
-    my @git_log_params = ('--parents', '--topo-order');
+    my @git_log_params = ('--pretty', '--parents', '--topo-order');
 
     if (defined $lastcommit) {
         push @git_log_params, "$lastcommit..$self->{module}";
     } else {
         push @git_log_params, $self->{module};
     }
-    open(GITLOG, '-|', 'git-log', @git_log_params) or die "Cannot call git-log: $!";
+    # git-rev-list is the backend / plumbing version of git-log
+    open(GITLOG, '-|', 'git-rev-list', @git_log_params) or die "Cannot call git-rev-list: $!";
 
     my @commits;
 

-- 
1.3.1.g24e1-dirty