Re: [PATCH 1/3] cg-mv doesn't work with bash 3.1.7 due to excessive quotes
- From
- Pavel Roskin <proski@gnu.org>
- Date
- Mar 10, 2006, 20:48 UTC
- Message-ID
- <1142023722.23830.8.camel@dv>
- In-Reply-To
- <1141395067.30343.14.camel@dv>
Hello, Petr!
On Fri, 2006-03-03 at 09:11 -0500, Pavel Roskin wrote:
Show 5 quoted lines
> On Thu, 2006-03-02 at 21:27 -0800, Junio C Hamano wrote:
> > Pavel Roskin <proski@gnu.org> writes:
> >
> > > - ARGS2["${#ARGS2[@]}"]="$_git_relpath${arg%/}"
> > > + ARGS2[${#ARGS2[@]}]="$_git_relpath${arg%/}"Any issues with this patch? FC5 is due in a week. Expect and outcry from the new bash 3.1.7 users if the fixed cogito is not available shortly.
Bash is not as wrong as it may seem. Left hand side in assignments is already a special case in earlier versions of bash, just not in the index:
bash 3.00.16 (FC4) $ f"oo"=bar bash: foo=bar: command not found $ foo["0"]=bar $
bash 3.1.7 (FC5) $ f"oo"=bar bash: foo=bar: command not found $ foo["0"]=bar bash: "0": syntax error: operand expected (error token is ""0"") $
-- Regards, Pavel Roskin