git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] New test to verify that when git-clone fails it cleans up the new directory.

From
Carl Worth <cworth@cworth.org>
Date
Feb 17, 2006, 21:33 UTC
Message-ID
<11402120081238-git-send-email-cworth@cworth.org>
In-Reply-To
<1140212006127-git-send-email-cworth@cworth.org>
Signed-off-by: Carl Worth <cworth@cworth.org>
---
 t/t5600-clone-fail-cleanup.sh |   36 ++++++++++++++++++++++++++++++++++++
 1 files changed, 36 insertions(+), 0 deletions(-)
 create mode 100755 t/t5600-clone-fail-cleanup.sh
0d8852c105e5f910ba53fc974a5d929a2136aecd
diff --git a/t/t5600-clone-fail-cleanup.sh b/t/t5600-clone-fail-cleanup.sh
new file mode 100755
index 0000000..0c6a363
--- /dev/null
+++ b/t/t5600-clone-fail-cleanup.sh
@@ -0,0 +1,36 @@
+#!/bin/sh
+#
+# Copyright (C) 2006 Carl D. Worth <cworth@cworth.org>
+#
+
+test_description='test git-clone to cleanup after failure
+
+This test covers the fact that if git-clone fails, it should remove
+the directory it created, to avoid the user having to manually
+remove the directory before attempting a clone again.'
+
+. ./test-lib.sh
+
+test_expect_failure \
+    'clone of non-existent source should fail' \
+    'git-clone foo bar'
+
+test_expect_failure \
+    'failed clone should not leave a directory' \
+    'cd bar'
+
+# Need a repo to clone
+test_create_repo foo
+
+# clone doesn't like it if there is no HEAD. Is that a bug?
+(cd foo && touch file && git add file && git commit -m 'add file' >/dev/null 2>&1)
+
+test_expect_success \
+    'clone should work now that source exists' \
+    'git-clone foo bar'
+
+test_expect_success \
+    'successfull clone must leave the directory' \
+    'cd bar'
+
+test_done
-- 
1.2.0.gf6e8
Previous: Carl Worth
Message 4 of 4 in “Making git-clone clean up when it fails”
  1. Carl WorthFeb 17, 2006
  2. 1/3 Trap exit to clean up created directory if clone fails.Carl Worth, Feb 17, 2006
  3. 2/3 Abstract test_create_repo out for use in tests.Carl Worth, Feb 17, 2006
  4. 3/3 New test to verify that when git-clone fails it cleans up the new directory.Carl Worth, Feb 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.