Re: Random notes about qgit

From: Pavel Roskin <proski@gnu.org>
Date: Dec 21, 2005, 16:22 UTC
Message-ID: <1135182156.5602.15.camel@dv>
In-Reply-To: <e5bfff550512210417p1d363017p9d08e3c55fc841d5@mail.gmail.com>

On Wed, 2005-12-21 at 13:17 +0100, Marco Costalba wrote:

Show 10 quoted lines

> On 12/21/05, Pavel Roskin <proski@gnu.org> wrote:
> 
> > Thanks for making the range dialog optional, but now I don't see any way
> > to see the local changes unless I re-enable the dialog.  I think it
> > should be an action activated from the menu - "diff local files to this
> > revision".  Or maybe the "local" radio button in the diff pane.
> >
> 
> Actually you could re-enable working dir diffs from
> menu->edit->settings->'git index'

Indeed.  Thank you!

> Do you think is too hidden?

It shouldn't be an option. It should be an action, available on demand, regardless of options. In the majority of cases, only diff to the head revision is needed, but some users may want to see diff against other revisions, e.g. when verifying manual merge.

Maybe there should be an option to check the local diff on startup and indicate it somehow (not necessarily in the revision list) if it's not empty.

But I'm not a GUI expert and I don't know how to make it easy to discover without being constantly in the way.

Show 10 quoted lines

> > Current qgit seems to have another crash, also annotation related.  Run
> > qgit on its own repository.  Select "Add range select dialog options",
> > then double click on src/commitimpl.cpp in the file list.  Sometimes it
> > works, sometimes it crashes like this:
> >
> > ASSERT getFileAnnotation: no revision
> > 9771bea705024b3d0a59e1b9144adf5d77ca82d1
> 
> I cannot reproduce the bug but please Pavel, add qDebug() lines
> in git.cpp as following:

OK, this will be a in separate thread.

Show 7 quoted lines

> > "View->Revision Diff" and "View->Archive Tree" work differently.  The
> > former doesn't allow to turn the pane off.  I'd like it to work like
> > "View->Archive Tree".  Neither can "Revision Diff" be closed from the
> > popup menu.
> >
> 
> Yes, "View->Revision Diff" should be a toggle action.  ;-)

OK

-- 
Regards,
Pavel Roskin