git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gqit: enable compiler warnings

From
PRPavel Roskin <proski@gnu.org>
Date
Dec 21, 2005, 02:11 UTC
Message-ID
<1135131068.1183.6.camel@dv>

The "-O2" flag should be separated from the threading support. Besides, it belongs to CCFLAGS (compile flags common to C and C++), not to CPPFLAGS (preprocessor flags). While at that, enable all warnings by -Wall, except those about non-virtual destructors, which are "inherited" from Qt. Portability is not affected since -O2 was already gcc-specific.

Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/SConstruct b/SConstruct
index 55fd206..b0b5d0f 100644
--- a/SConstruct
+++ b/SConstruct
@@ -27,8 +27,10 @@ env['ENV']['HOME'] = os.environ['HOME'] 
 
 installDir = env['HOME']+'/bin'
 
+env.Append( CCFLAGS = ['-O2', '-Wall' ,'-Wno-non-virtual-dtor'] )
+
 ## Uncomment the following if you need threading support threading
-env.Append( CPPFLAGS = ['-O2', '-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )
+env.Append( CPPFLAGS = ['-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )
 if os.uname()[0] == "FreeBSD":
 	env.Append(LINKFLAGS=["-pthread"])
 
-- 
Regards,
Pavel Roskin
Next: Marco Costalba
Message 1 of 2 in “gqit: enable compiler warnings”
  1. gqit: enable compiler warningsPavel Roskin, Dec 21, 2005
  2. Marco CostalbaDec 21, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.