Re: Latest cogito broken with bash-3.1

From: Marcel Holtmann <marcel@holtmann.org>
Date: Dec 11, 2005, 08:31 UTC
Message-ID: <1134289867.9541.9.camel@blade>
In-Reply-To: <20051211001106.GV22159@pasky.or.cz>

Hi Petr,

Show 15 quoted lines

> > The cogito is the latest from kernel.org and when calling cg-commit it
> > fails with this message:
> > 
> > cg-commit: line 200: syntax error near unexpected token `('
> > cg-commit: line 200: `       eval commitfiles=($(cat $filter | path_xargs git-diff-index -r -m HEAD -- | \'
> > 
> > I played a little bit with it and it seems all the eval statements are
> > broken with this bash version. I have no clue how to fix this, but maybe
> > you do.
> 
>   it seems like the newer bash is stricter than the older versions in
> some obscure regards. Quoting the eval arguments (which is the proper
> thing to do anyway) fixed that particular problem; I've hit another
> problem during a test commit wrt. whitespace separators - I've fixed
> that too, and pushed out.

it's now working again. Thanks. What do you think about another release? I haven't checked the other distributions yet, but I just saw that Debian unstable also moved to version 3.1 of bash.

There exists also another problem with the new bash. It is the broken pipe error from cg-log.

cg-log: line 141: echo: write error: Broken pipe

The line number varies depending how much you scrolled and when you scrolled to the end no broken pipe error comes up. Do you have any idea on how to deal with this. I saw your comment about that bash is broken and the extra trap command, but it doesn't help. I never saw that problem with older versions of bash.

Regards

Marcel