git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Make logerror() and loginfo() static

From
PRPavel Roskin <proski@gnu.org>
Date
Sep 29, 2005, 20:53 UTC
Message-ID
<1128027194.24397.50.camel@dv>
Make logerror() and loginfo() static

logerror() and loginfo() in daemon.c are never declared and never called from other files, therefore they should be declared static. Found by sparse.

Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/daemon.c b/daemon.c
--- a/daemon.c
+++ b/daemon.c
@@ -57,7 +57,7 @@ static void logreport(int priority, cons
 	write(2, buf, buflen);
 }
 
-void logerror(const char *err, ...)
+static void logerror(const char *err, ...)
 {
 	va_list params;
 	va_start(params, err);
@@ -65,7 +65,7 @@ void logerror(const char *err, ...)
 	va_end(params);
 }
 
-void loginfo(const char *err, ...)
+static void loginfo(const char *err, ...)
 {
 	va_list params;
 	if (!verbose)
-- 
Regards,
Pavel Roskin
Next: Junio C Hamano
Message 1 of 2 in “Make logerror() and loginfo() static”
  1. Make logerror() and loginfo() staticPavel Roskin, Sep 29, 2005
  2. Junio C HamanoSep 30, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.