Re: [PATCH] stgit: allow spaces in filenames

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jul 13, 2005, 21:26 UTC
Message-ID: <1121290004.6876.11.camel@localhost.localdomain>
In-Reply-To: <42D55AC9.4000506@gmail.com>

On Wed, 2005-07-13 at 14:17 -0400, Bryan Larsen wrote:

> Catalin Marinas wrote:
> I would have hoped that emacs py-mode would "do the right thing". 
> Anybody know how to make it do what Catalin wants?

It looks like the python-mode in my emacs does the right thing. You could add something like below in your .emacs file:

(add-hook 'python-mode-hook
          #'(lambda ()
              (setq indent-tabs-mode nil)))

Otherwise, select the whole buffer and do a "M-x untabify".

Show 5 quoted lines

> > What's the reason for having 'fin' as well? It doesn't seem to be used
> > (this is found in other parts of the patch as well).
> 
> popen does not support bypassing the shell by using vectors of 
> arguments.  Only popen2 and friends have this capability.

But the manual says that it is not possible to get the exit code of the child process with popen2 (at least not in python 2.3). You would need to use the Popen3 and Popen4 classes in the popen2 module.

Does it make that big difference if the commands are invoked via the shell? I haven't run any tests.

Show 7 quoted lines

> > I'm not sure whether the GIT guys are happy for us to use this mailing
> > list for StGIT. If the StGIT traffic increases, I will try to create a
> > separate mailing list (maybe using a site like sf.net).
> > 
> 
> I'd very much like to stay on the same list.  By the same logic, cogito 
> should have it's own list as well...

I'd like this too and it's probably OK with a low traffic (we'll see if we receive complaints :-) ).

Catalin