Re: Re: [patch pasky] update gitcancel.sh to handle modes as well

From: Martin Schlemmer <azarah@nosferatu.za.org>
Date: Apr 14, 2005, 23:14 UTC
Message-ID: <1113520447.23299.137.camel@nosferatu.lan>
In-Reply-To: <20050414230712.GT22699@pasky.ji.cz>

On Fri, 2005-04-15 at 01:07 +0200, Petr Baudis wrote:

Show 28 quoted lines

> Dear diary, on Fri, Apr 15, 2005 at 01:04:50AM CEST, I got a letter
> where Martin Schlemmer <azarah@nosferatu.za.org> told me that...
> > Rather use checkout-cache to sync our tree, as should do the right thing
> > instead of diffing (cancel imply just blow away everything).
> > 
> > Signed-off-by: Martin Schlemmer <azarah@nosferatu.za.org>
> > 
> > gitcancel.sh:  839b3c58f20f6eb8412f499a891e007e2e67d114
> > --- 839b3c58f20f6eb8412f499a891e007e2e67d114/gitcancel.sh
> > +++ uncommitted/gitcancel.sh
> > @@ -10,9 +10,8 @@
> >  #
> >  # Takes no arguments. Takes the evil changes from the tree.
> > 
> > -# FIXME: Does not revert mode changes!
> > 
> > -show-diff | patch -p0 -R
> >  rm -f .git/add-queue .git/rm-queue
> > +checkout-cache -q -f -a
> > 
> >  update-cache --refresh
> 
> Why -q?
> 
> Never make things silent unless you really know what are you doing and
> why. The same goes for popular throwing of -f to rm's of files which
> should always exist or 2>/dev/null for cats.
>

Uhm, no particular reason (other than perhaps working usually on stuff where too much info just confuses the user). If its fine in spirit, the -q can go.

-- 
Martin Schlemmer