git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] config: retry acquiring config.lock, configurable via core.configLockTimeout

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 7, 2026, 11:39 UTC
Message-ID
<10bb26f4-38e7-1bb8-d2d9-4d3e2ef52adc@gmx.de>
In-Reply-To
<f449d0db-0434-f870-c69f-793f2b096816@gmx.de>
Hi,
On Thu, 28 May 2026, Johannes Schindelin wrote:
Show 15 quoted lines
> On Sun, 17 May 2026, Joerg Thalheim wrote:
> 
> > I matched the core.filesRefLockTimeout naming rather than reusing
> > microsoft/git's core.configWriteLockTimeoutMS, but can switch if the
> > downstream compat matters more.
> 
> I see that there is quite a bit of precedent for naming a config setting
> `*Timeout` and implying that it specifies milliseconds, e.g.
> https://git-scm.com/docs/git-config#Documentation/git-config.txt-corefilesRefLockTimeout
> 
> In general, I am pretty wary of unit-less numbers [*1*], that's why I
> chose that "MS" suffix. However, the prior art in Git is clear, and I
> should not have missed it. Therefore, I have no objections against
> `core.configLockTimeout` as-is; I'll take care of providing a smooth
> upgrade path in Microsoft Git.

For the record: I meant this feedback as _supporting_ the patch. Now I see it is stalled... I do not really see any reason for this to be blocked from promoting to `next` and then `master`, though.

Ciao, Johannes

Previous: Junio C HamanoNext: Junio C Hamano
Message 16 of 18 in “config: retry acquiring config.lock for 100ms”
  1. config: retry acquiring config.lock for 100msJoerg Thalheim, Apr 3, 2026
  2. Junio C HamanoApr 3, 2026
  3. Patrick SteinhardtApr 8, 2026
  4. Junio C HamanoMay 11, 2026
  5. Patrick SteinhardtMay 11, 2026
  6. Jörg ThalheimMay 11, 2026
  7. Patrick SteinhardtMay 11, 2026
  8. Johannes SchindelinMay 17, 2026
  9. config: retry acquiring config.lock, configurable via core.configLockTimeoutJoerg Thalheim, May 17, 2026
  10. Junio C HamanoMay 18, 2026
  11. Patrick SteinhardtMay 18, 2026
  12. Johannes SchindelinJul 8, 2026
  13. Junio C HamanoJul 8, 2026
  14. Johannes SchindelinMay 28, 2026
  15. Junio C HamanoMay 28, 2026
  16. Johannes SchindelinJul 7, 2026
  17. Junio C HamanoJul 7, 2026
  18. Junio C HamanoJul 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.