[PATCH v2 4/4] bisect: fix memory leak when returning best element
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Nov 5, 2017, 20:24 UTC
- Message-ID
- <106187fd063f3eb21ec979d8a59f662d77c4b2f4.1509906092.git.martin.agren@gmail.com>
- In-Reply-To
- <cover.1509906092.git.martin.agren@gmail.com>
When `find_bisection()` returns a single list entry, it leaks the other entries. Move the to-be-returned item to the front and free the remainder.
Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- bisect.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bisect.c b/bisect.c index b1941505b..3756f127b 100644 --- a/bisect.c +++ b/bisect.c @@ -399,8 +399,12 @@ void find_bisection(struct commit_list **commit_list, int *reaches, /* Do the real work of finding bisection commit. */ best = do_find_bisection(list, nr, weights, find_all); if (best) { - if (!find_all) + if (!find_all) { + list->item = best->item; + free_commit_list(list->next); + best = list; best->next = NULL; + } *reaches = weight(best); } free(weights);
-- 2.15.0.415.gac1375d7e