Re: What's cooking in git.git (Nov 2024, #07; Wed, 20)

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Nov 21, 2024, 15:31 UTC
Message-ID: <10282b43-4b1c-4e8d-a2cd-2aa725622e90@app.fastmail.com>
In-Reply-To: <xmqq5xogg2to.fsf@gitster.g>

On Thu, Nov 21, 2024, at 13:59, Junio C Hamano wrote:

Show 8 quoted lines

> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>> What should be done about what one might call a
>> trailer topic version for simple topics that might get included in `next` soon
>> after being proposed?
>
> Sorry, but I do not understand what you are asking here.  Can you
> elaborate?

The patch got an Ack from Christian.[1] The patch submitter is supposed to add trailers like `Acked-by` in subsequent versions according to SubmittingPatches. But this one went straight from proposal to `next` as far as I could see. And you’re not supposed to create updates for topics which are in `next` already. Or at least that’s my impression.

So the question is what to do about such topic updates for adding trailers when the topic goes into `next` (apparently) straight away? I just let it sit there for the week in case someone had any counter-proposals for the glossary entry. So I didn’t post a v2 with the added trailer before the next What’s Cooking.

It’s not important whether the patch/commit might be missing one proposed trailer. I’m just wondering what to do in cases like this on future topics.

🔗 1: https://lore.kernel.org/git/CAP8UFD3p3ts_7kvk_Zm2efhcPUcEFnLcLFPAqzb40d46BTVzyA@mail.gmail.com/

-- 
Kristoffer Haugsbakk