Re: [PATCH] bash completion: remove deprecated --prune from git-gc
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Dec 15, 2008, 16:51 UTC
- Message-ID
- <0zFE1s-V9qRpO8jkUYC05iTwrouhwDxFz3yJgo_P3R0KZaGeJ6jKSg@cipher.nrlssc.navy.mil>
- In-Reply-To
- <20081214111213.GA6499@coredump.intra.peff.net>
Jeff King wrote:
Show 12 quoted lines
> On Sun, Dec 14, 2008 at 11:38:17AM +0100, Johannes Schindelin wrote: > >>> - __gitcomp "--prune --aggressive" >>> + __gitcomp "--aggressive" >> git gc --prune is deprecated? That's news to me. > > Check out 9e7d501 (builtin-gc.c: deprecate --prune, it now really has no > effect, 2008-05-09). > > Which annoyingly has no discussion about _why_ it no longer has an > effect. But I suspect it has something to do with 25ee973 (gc: call > "prune --expire 2.weeks.ago" by default, 2008-03-12) by you.
I think the nail in the coffin for --prune was a37cce3b, which preceded 9e7d501. I guess the commit message for 9e7d501 made sense with a37cce3b as a reference. There was another commit around the same time which claimed that --prune was deprecated even though it still provided some functionality, hence the "...really has no effect" part.
I definitely remember that Johannes implemented the gc.pruneExpire functionality, so his "That's news to me" made me laugh. Thanks for the chuckle Johannes. :)
-brandon