Re: [PATCH v2 4/4] gc: remove broken symrefs
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 6, 2015, 13:59 UTC
- Message-ID
- <0fff9005109d99176ae99b7bfde6c576@dscho.org>
Hi Junio,
On 2015-10-06 00:06, Junio C Hamano wrote:
Show 20 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes: > >> Oh, I appreciate your feedback. I am actually not all *that* certain >> that removing the broken symref is the correct thing. It is this sort >> of fruitful exchange that allows me to throw out an idea and be >> relatively certain that something better will come out of v3 or v8 of >> the patch series than what I had in mind. >> >> To be honest, the most important outcome is probably 2/4 -- which >> should be enough to fix the issue reported by the Git for Windows >> user. I could adjust the test so that it no longer insists that >> origin/HEAD` be deleted, but still requires that `git gc` succeeds. >> >> I would have no problem to let this sit for a couple of days until >> the final verdict. > > ... and a few days have passed. I am tempted to do the easy bits > first, discarding the parts that both of us feel iffy for now > without prejudice, keeping the first two commits with a bit of > tweak.
I agree. And I just sent out v3 of the patch series.
Thanks, Dscho