[PATCH 3/5] MyFirstObjectWalk: fix filtered object walk
- From
Dirk Gouders <dirk@gouders.net>
- Date
- Mar 11, 2024, 12:47 UTC
- Message-ID
- <0f67a161efc2635bb453eff2f6ab34b94c8794ae.1710192973.git.dirk@gouders.net>
- In-Reply-To
- <cover.1710192973.git.dirk@gouders.net>
Commit f0d2f849 (MyFirstObjectWalk: update recommended usage) changed a call of parse_list_objects_filter() in a way that probably never worked: parse_list_objects_filter() always needed a pointer as its first argument.
Fix this by removing the CALLOC_ARRAY and passing the address of rev->filter to parse_list_objects_filter() in accordance to such a call in revisions.c, for example.
Fixes: f0d2f849 (MyFirstObjectWalk: update recommended usage) Cc: Derrick Stolee <stolee@gmail.com> Signed-off-by: Dirk Gouders <dirk@gouders.net> --- Documentation/MyFirstObjectWalk.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt index c33d22ae99..a06c712e46 100644 --- a/Documentation/MyFirstObjectWalk.txt +++ b/Documentation/MyFirstObjectWalk.txt @@ -734,8 +734,8 @@ walk we've just performed: } else { trace_printf( _("Filtered object walk with filterspec 'tree:1'.\n")); - CALLOC_ARRAY(rev->filter, 1); - parse_list_objects_filter(rev->filter, "tree:1"); + + parse_list_objects_filter(&rev->filter, "tree:1"); } traverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);
-- 2.43.0