Re: [PATCH 5/5] path.c: don't call the match function without value in trie_find()
On Mon, 2019-10-21 at 18:00 +0200, SZEDER Gábor wrote:
Show 5 quoted lines
> Add the missing condition to trie_find() so it will never invoke the
> match function with a non-existing value. check_common() will then
> no
> longer have to check that it got a non-NULL value, so remove that
> condition.
Show 10 quoted lines
>
> /* Partial path normalization: skip consecutive slashes */
> while (key[0] == '/' && key[1] == '/')
> @@ -345,9 +349,6 @@ static int check_common(const char *unmatched,
> void *value, void *baton)
> {
> struct common_dir *dir = value;
>
> - if (!dir)
> - return 0;Do we want to assert(dir) here?
Overall, LGTM. Thanks for the clean-up.
David Turner <novalis@novalis.org>