[PATCH 1/2] pack-objects: allow --filter without --stdout
- From
John Cai via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jan 27, 2022, 01:49 UTC
- Message-ID
- <0eec9b117dad5e3cfddf8a17ea74af9a4e23e102.1643248180.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1206.git.git.1643248180.gitgitgadget@gmail.com>
From: John Cai <johncai86@gmail.com>
9535ce7 taught pack-objects to use filtering, but added a requirement of the --stdout since a partial clone mechanism was not yet in place to handle missing objects. Since then, changes like 9e27beaa and others added support to dynamically fetch objects that were missing.
Remove the --stdout requirement so that in the next commit, repack can pass --filter to pack-objects to omit certain objects from the packfile.
Based-on-patch-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: John Cai <johncai86@gmail.com> --- builtin/pack-objects.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index ba2006f2212..2d1ecb18784 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -4075,8 +4075,6 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix) unpack_unreachable_expiration = 0; if (filter_options.choice) { - if (!pack_to_stdout) - die(_("cannot use --filter without --stdout")); if (stdin_packs) die(_("cannot use --filter with --stdin-packs")); }
-- gitgitgadget