Re: [PATCH] [PATCH] [Outreachy] builtin/patch-id.c: clarify SHA1 usage for patch IDs

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 15, 2025, 13:59 UTC
Message-ID: <0ebb19d7-b8a5-4792-841f-fa5a6b9c4d63@app.fastmail.com>
In-Reply-To: <xmqqbjm8waki.fsf@gitster.g>

On Wed, Oct 15, 2025, at 15:37, Junio C Hamano wrote:

Show 18 quoted lines

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
>> Given that context, I think allowing the specification of an algorithm
>> would allow people to say, "Yes, I am in a SHA-256 repository, but I
>> want SHA-1," or vice versa, which would work with your use case better.
>
> That is sensible.
>
> In short, the automatic choice is to use the repository's hash
> inside a repository, or use the then-default algorithm (which comes
> from the preimage of the patch we discussed in this thread) outside
> a repository.  We want a "Use this hash algorithm, ignoring the
> automatic choice" command line option that overrides it.
>
> If we were to do configuration variables, we may need two.  One to
> replace only the fallback part (i.e. outside a repository, instead
> of using whatever then-current algorithm, use this one), and the
> other to act as if the above command line option is always given.

I’ve been wondering. Why does a command which in my impression is only useful for scripting have configuration variables? Shouldn’t plumbing commands in general avoid that since they can end up relying on configuration state if they end up in scripts?

I want `--stable` so I always try to use that, not the corresponding configuration variable.

Show 5 quoted lines

>
> But as always, starting with only a command line option would be a
> prudent way forward.
>
> Thanks.