Re: [PATCH] odb: do not use "blank" substitute for NULL

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Dec 18, 2025, 08:02 UTC
Message-ID: <0e860421-8f8c-4bf9-8ad8-82fe269a7a9d@app.fastmail.com>
In-Reply-To: <a31e054e-0eb2-48b9-a802-3592a737d1e3@nvidia.com>

On Thu, Dec 18, 2025, at 05:51, Aaron Plattner wrote:

Show 12 quoted lines

>>[snip]
>> By explicitly handling NULL input, we no longer have to worry about
>> it.
>
> This reasoning makes sense to me.
>
> Would it make sense to add a
>
> Fixes: 385e18810f10 ("packfile: introduce function to read object info
> from a store")
>
> line?

This project typically does not use that trailer/tag. Only trailers that attribute people are recommended. There are exceptions, like some recent usages of

    Best-viewed-with: <option to git-log(1)/git-show(1)>

If a commit fixes some other commit it might be referenced somewhere in the message text.

Commits are referenced with:[1]

     git show -s --pretty=reference <commit>

The maintainer uses `--abbrev=8` (simplified):[2]

    git show --date=short -s --abbrev=8 --pretty='format:%h (%s, %ad)' "$1"

† 1: Documentation/SubmittingPatches [2]: https://lore.kernel.org/git/xmqq34j5h7v9.fsf@gitster.g/

>[snip]