Re: Build race observed with git 2.34.1 - hook-list.h wasn't generated yet

From: Victoria Dye <vdye@github.com>
Date: Dec 7, 2021, 14:34 UTC
Message-ID: <0e3e3a4f-f6af-d8df-8973-255ed7b1b7ef@github.com>
In-Reply-To: <20211207113101.69686-1-alex.kanavin@gmail.com>

Alexander Kanavin wrote:

Show 16 quoted lines

> Specifically:
> 
>  builtin/bugreport.c:7:10: fatal error: hook-list.h: No such file or directory
> |     7 | #include "hook-list.h"
> |       |          ^~~~~~~~~~~~~
> | compilation terminated.
> 
> Please see here for the full log:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/4427/steps/14/logs/stdio
> 
> Seems like COMPUTE_HEADER_DEPENDENCIES isn't working quite right? I meanwhile have set it to
> 'no'.
> 
> Thanks,
> Alexander
>

I've encountered this as well, and it appears to be a dependency graph issue. For me, compilation was fixed by a patch [1] that isn't in next or master yet ("Needs review" - ab/make-dependency [2]). If this an important fix to fast-track (I'll defer to more experienced contributors to determine that), it might speed up review to separate that patch from the rest of the series?

[1] https://lore.kernel.org/git/patch-v4-19.23-2710f8af6cd-20211117T101807Z-avarab@gmail.com/

[2] https://lore.kernel.org/git/xmqqbl1xqheu.fsf@gitster.g/