git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] send-email: make it easy to discern the messages for each patch

From
DSDragan Simic <dsimic@manjaro.org>
Date
Apr 4, 2024, 20:34 UTC
Message-ID
<0e087ed992def0746f3d437253248904c2126464.1712262791.git.dsimic@manjaro.org>

When sending multiple patches at once, without confirming the sending of each patch separately, the displayed result statuses of sending each patch become bunched together with the messages produced for the subsequent patch. This unnecessarily makes discerning each of the result statuses a bit difficult, as visible in the sample output excerpt below:

    ...
    MIME-Version: 1.0
    Content-Transfer-Encoding: 8bit
    Result: 250
    OK. Log says:
    ...

As visible above, bunching the "Result: <status-code>" lines together with the messages produced for the subsequent patch makes the output unreadable. Thus, let's add a newline after each displayed result status, to make the outputs more readable, as visible in the sample output excerpt below:

    ...
    MIME-Version: 1.0
    Content-Transfer-Encoding: 8bit
    Result: 250
    OK. Log says:
    ...

This change also adds a newline after the last produced result status, which may be seen as redundant. Though, it doesn't look too bad, and making that last newline not displayed would make the code much more complex, which would not be worth neither the time and effort now, nor the additional maintenance burden in the future.

The way the additional newline separators are introduced to the source code also moves the already existing newline characters out of the translatable strings, which should help a bit with the translation efforts.

While there, remove one spotted stray newline in the source code.
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
---
Notes:
     * send-email: make produced outputs more readable by separating
       the result statuses from the subsequent patch outputs
    
    Changes in v2:
        - Improved the way additional newline separators are introduced to
          the source code, as suggested by Junio, [1], to help a bit with
          the translation efforts
        - Improved the patch subject and description a bit, to provide some
          additional information, as suggested by Junio [1]
    
    Notes for v1:
        - This is a resubmission of the patch I submitted about a week and
          a half ago. [2]  The patch subject in the original submission was
          selected in a bit unfortunate way, which this submission corrects,
          and also improves the patch description a bit.
        - There are no changes to the patch itself, vs. the original patch.
    
    Link to v1: https://lore.kernel.org/git/62553db377c28458883b66bcdc0c58cc0f32d15b.1712250366.git.dsimic@manjaro.org/T/#u
    
    [1] https://lore.kernel.org/git/xmqqy19tylrm.fsf@gitster.g/
    [2] https://lore.kernel.org/git/6ee28707b9eb8bd8fdfc8756c351455c6bc3bb62.1711447365.git.dsimic@manjaro.org/
 git-send-email.perl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 821b2b3a135a..ac0c691d3a46 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1576,7 +1576,6 @@ sub send_message {
 		print $sm "$header\n$message";
 		close $sm or die $!;
 	} else {
-
 		if (!defined $smtp_server) {
 			die __("The required SMTP server is not properly defined.")
 		}
@@ -1686,10 +1685,12 @@ sub send_message {
 		print $header, "\n";
 		if ($smtp) {
 			print __("Result: "), $smtp->code, ' ',
-				($smtp->message =~ /\n([^\n]+\n)$/s), "\n";
+				($smtp->message =~ /\n([^\n]+\n)$/s);
 		} else {
-			print __("Result: OK\n");
+			print __("Result: OK");
 		}
+		# Make it easy to discern the messages for each patch
+		print "\n\n";
 	}
 
 	return 1;
Next: Junio C Hamano
Message 1 of 9 in “send-email: make it easy to discern the messages for each patch”
  1. send-email: make it easy to discern the messages for each patchDragan Simic, Apr 4, 2024
  2. Junio C HamanoApr 4, 2024
  3. Dragan SimicApr 4, 2024
  4. Junio C HamanoApr 5, 2024
  5. Dragan SimicApr 5, 2024
  6. Junio C HamanoApr 5, 2024
  7. Dragan SimicApr 5, 2024
  8. Kristoffer HaugsbakkApr 5, 2024
  9. Dragan SimicApr 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.