Re: [PATCH] mem-pool: fix big allocations

From: René Scharfe <l.s.r@web.de>
Date: Dec 29, 2023, 06:53 UTC
Message-ID: <0dd59d8e-0175-43ef-893d-3352a3f5f1c4@web.de>
In-Reply-To: <48821d3f-2e30-4bce-b9e8-e4199c24e251@gmail.com>

Am 28.12.23 um 20:34 schrieb phillip.wood123@gmail.com:

Show 5 quoted lines

>
> Exactly, my worry is that if the comparison fails it is likely that
> there will have been undefined behavior involved in calculating the
> pointer before we get to the comparison in which case so casting to
> uintptr_t in the comparison does not help.

If there's undefined behavior (UB) somewhere in the test or the tested unit then the compiler could skip any checks and report success anyway. Not adding UB in the test framework and tests is the least we can do.

Perhaps disabling link-time optimization would allow us to shield the unit tests from UB in the tested code, in the sense that the compiler would then not be able to skip checks.

René