Re: git-gui: automatically move focus to staged file before typing commit message?

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 14, 2019, 21:26 UTC
Message-ID: <0db5470e-5044-d5b3-8f04-f40cfbd8cf44@kdbg.org>
In-Reply-To: <20190914211509.sjy6lh2rlcl32lj5@yadavpratyush.com>

Am 14.09.19 um 23:15 schrieb Pratyush Yadav:

Show 12 quoted lines

> On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote:
>> When the user
>> stages the last file in the "Unstaged Changes" widget, no file is
>> selected and the diff view becomes blank. When this is the case, I
>> would prefer that git-gui automatically selects one of the staged
>> files and shows it in the diff widget before I type up my commit
>> message. Naturally, this automatic selection should **only** happen
>> when the user chooses focus the "Commit Message" widget.
> 
> Why should it only happen when the commit message widget is selected? 
> What's wrong with directly switching focus when all the files are 
> staged?

That was my reaction, too.

> What I have in mind is once there are no more files to stage, the focus 
> directly goes to the staged files section, and the first staged file 
> gets selected.

... or the last one that was staged. Typically, it is a fixup found during testing that is staged last. Then I like to have a look at the complete staged changes of that file.

 Then if you want you can type in the commit message. And

> conversely, when unstaging things, once all files are unstaged, the 
> focus goes directly to the unstaged files section.

Same here.

-- Hannes