Re: Git Test Coverage Report (Thursday, May 30th)

From: Derrick Stolee <stolee@gmail.com>
Date: May 31, 2019, 17:51 UTC
Message-ID: <0d7dbfe6-53df-1df8-ac94-4dfab85bbc9f@gmail.com>
In-Reply-To: <e18e4391-a574-1f4b-88c7-890ada116f51@gmail.com>

On 5/30/2019 2:24 PM, Derrick Stolee wrote:

Show 21 quoted lines

> Further, these tests failed
>
> t3400-rebase.sh                           (Wstat: 256 Tests: 28 Failed: 2)
>   Failed tests:  20, 28
>   Non-zero exit status: 1
> t3420-rebase-autostash.sh                 (Wstat: 256 Tests: 38 Failed: 6)
>   Failed tests:  6, 13, 16, 23, 26, 33
>   Non-zero exit status: 1
> t3404-rebase-interactive.sh               (Wstat: 256 Tests: 110 Failed: 5)
>   Failed tests:  3, 9-10, 100-101
>   Non-zero exit status: 1
> t5521-pull-options.sh                     (Wstat: 256 Tests: 19 Failed: 1)
>   Failed test:  3
>   Non-zero exit status: 1
> t5551-http-fetch-smart.sh                 (Wstat: 256 Tests: 37 Failed: 1)
>   Failed test:  26
>   Non-zero exit status: 1
> 
> They don't fail locally, so perhaps we shouldn't blindly trust the coverage data
> until I work out why these errors occurred. (Many of the cases I called out
> above I couldn't hit locally with a die() statement.)

These tests all failed during the second run that set optional GIT_TEST environment variables. Specifically, GIT_TEST_REBASE_USE_BUILTIN=false caused these tests to break. We now output this message:

	warning: the rebase.useBuiltin support has been removed!
	See its entry in 'git help config' for details.

I'm removing that variable from the build definition.

Thanks, -Stolee