git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/commit-graph.c: remove subcommand-less usage string

From
Derrick Stolee <stolee@gmail.com>
Date
Oct 25, 2019, 17:35 UTC
Message-ID
<0ba48f8e-3869-ff08-b46d-53feb7675d2b@gmail.com>
In-Reply-To
<20191025164909.354-1-szeder.dev@gmail.com>
On 10/25/2019 12:49 PM, SZEDER Gábor wrote:
Show 32 quoted lines
> The first line in 'git commit-graph's usage string indicates that this
> command can be invoked without specifying a subcommand.  However, this
> is not the case:
> 
>   $ git commit-graph
>   usage: git commit-graph [--object-dir <objdir>]
>      or: git commit-graph read [--object-dir <objdir>]
>   [...]
>   $ echo $?
>   129
> 
> Remove this line from the usage string.
> 
> The synopsis in the manpage doesn't contain this line.
> 
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
>  builtin/commit-graph.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
> index c6219ebe11..4d9b9c862f 100644
> --- a/builtin/commit-graph.c
> +++ b/builtin/commit-graph.c
> @@ -8,7 +8,6 @@
>  #include "object-store.h"
>  
>  static char const * const builtin_commit_graph_usage[] = {
> -	N_("git commit-graph [--object-dir <objdir>]"),
>  	N_("git commit-graph read [--object-dir <objdir>]"),
>  	N_("git commit-graph verify [--object-dir <objdir>] [--shallow] [--[no-]progress]"),
>  	N_("git commit-graph write [--object-dir <objdir>] [--append|--split] [--reachable|--stdin-packs|--stdin-commits] [--[no-]progress] <split options>"),
Good catch! Thanks for cleaning this up.
-Stolee
Previous: SZEDER Gábor
Message 2 of 2 in “builtin/commit-graph.c: remove subcommand-less usage string”
  1. builtin/commit-graph.c: remove subcommand-less usage stringSZEDER Gábor, Oct 25, 2019
  2. Derrick StoleeOct 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.