Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

From: Mathieu Liénard--Mayor <mathieu.lienard--mayor@ensimag.fr>
Date: Jun 18, 2013, 10:54 UTC
Message-ID: <0ad4bd4930efddcbaa5ed958c6758894@ensibm.imag.fr>
In-Reply-To: <CALkWK0=vytkxM3yzVaed+i3Q+RpvH=tSLndf=vUmiYC=sn=nFg@mail.gmail.com>

Le 2013-06-18 12:47, Ramkumar Ramachandra a écrit :

Show 19 quoted lines

> Jorge-Juan.Garcia-Garcia@ensimag.imag.fr wrote:
>> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
>> index 9f46f22..87641bc 100755
>> --- a/t/t9001-send-email.sh
>> +++ b/t/t9001-send-email.sh
>> @@ -1349,4 +1349,39 @@ test_expect_success $PREREQ 
>> 'sendemail.aliasfile=~/.mailrc' '
>>         grep "^!someone@example\.org!$" commandline1
>>  '
>>
>> -test_done
>> +test_expect_success $PREREQ 'setup expected-list' '
>> [...]
>> +test_expect_success $PREREQ 'use email list in --cc --to and --bcc' 
>> '
>
> What is the meaning of this test?  It looks like you've run git
> send-email twice in exactly the same way, and compared their outputs
> (after smudging the unstable headers).

The first one uses one flag per email address, just like we had to do so far. The second one uses one email-list per flag, which is the new feature we're introducing. Then we compare the output of the two, and expect it to be exactly the same.

Shouldn't

$ git send-email --cc 'foo@example.com' --cc 'bar@example.com'

and

$ git send-email --cc 'foo@example.com, bar@example.com'

have the exact same effect ?

-- 
Mathieu Liénard--Mayor,
2nd year at Grenoble INP - ENSIMAG
(+33)6 80 56 30 02