Re: [PATCH v4 0/4] interpret-trailers: add --where, --if-exists, --if-missing
On 01/08/2017 11:03, Paolo Bonzini wrote:
Show 21 quoted lines
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> These options are useful to experiment with "git interpret-trailers"
> without having to tinker with .gitconfig (Junio said git should ahve
> done this first and only added configuration afterwards). It can
> be useful in the case where you want a different placement for the trailer,
> or for scripts/aliases that don't want to rely on specific .gitconfig
> settings.
>
> Compared to v2, the main change is that option order on the command-line
> is respected. That is,
>
> --trailer 'acked-by: foo' --where end --trailer 'signed-off-by: me'
>
> will only apply where=end to the second trailer. Likewise,
>
> --where end --trailer 'signed-off-by: me' --no-where \
> --trailer 'acked-by: foo'
>
> will only apply it to the first, reverting to trailer.*.where for the
> "acked-by" trailer.
Junio, I see you haven't yet applied this v4 to origin/pu, did you miss it?
Thanks,
Paolo
Show 22 quoted lines
> Paolo
>
> v1->v2: support --no-* options, minor code fixes
>
> v2->v3: largely rewritten to respect option order on the command-line;
> keep trailer.h namespace clean (Christian)
>
> v3->v4: fix compilation warnings (Junio), added documentation fix
>
> Paolo Bonzini (4):
> trailers: export action enums and corresponding lookup functions
> trailers: introduce struct new_trailer_item
> interpret-trailers: add options for actions
> interpret-trailers: fix documentation typo
>
> Documentation/git-interpret-trailers.txt | 27 ++++++-
> builtin/interpret-trailers.c | 73 +++++++++++++++++--
> t/t7513-interpret-trailers.sh | 66 +++++++++++++++++
> trailer.c | 118 +++++++++++++++++++------------
> trailer.h | 43 ++++++++++-
> 5 files changed, 274 insertions(+), 53 deletions(-)
>
Paolo Bonzini <bonzini@gnu.org>