Re: Failure in t5516, tests 15 and 16

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Jun 27, 2007, 01:59 UTC
Message-ID: <0EE674FF-3749-43CB-B1CB-7FCF5860D025@silverinsanity.com>
In-Reply-To: <7v4pkuuq5u.fsf@assigned-by-dhcp.pobox.com>

On Jun 26, 2007, at 9:44 PM, Junio C Hamano wrote:

Show 8 quoted lines

> Can you check "cd t && sh -x t5516-fetch-push.sh -i -v"?
>
> I am suspecting that
>
>                 test "$( cd testrepo && git show-ref | wc -l )" = 1
>
> may have an interesting effect when "wc -l" emits extra
> whitespaces.  Does this fix it for you?

Exactly right. This bit me a while back on some other test as well. Should have thought of it this time. Removing the quotes (done manually, as it was faster than extracting your patch from the mail) fixed it and that test works properly now. I'm now getting errors in some CVS test... I'll figure that out later, but it appears completely unrelated.

I'm beginning to despise several of the OS X utilities. I wonder if this is inherited from some BSD, or if it's all new. Doesn't matter though, if you'd be so kind as to remove those quotes from git.git. :-)

~~ Brian