Re: [PATCH] commit-graph: use timestamp_t for max parent generation accumulator
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Jun 15, 2026, 11:44 UTC
- Message-ID
- <09e50180-e165-48d8-a9d0-485283342f5c@gmail.com>
- In-Reply-To
- <ai-zzWn9Ls6-j9h8@pks.im>
On 6/15/26 4:11 AM, Patrick Steinhardt wrote:
Show 8 quoted lines
> On Sun, Jun 14, 2026 at 06:57:50AM +0000, Elijah Newren via GitGitGadget wrote: >> commit-graph: use timestamp_t for max parent generation accumulator >> >> We found a few repositories in the wild with commits whose authors were >> apparently on a computer in the year 2120 when they recorded their >> commits. Apparently, in a century from now, some folks are going to have >> a really weird timezone as well (-13068837), though the timezone doesn't >> factor into this patch at all.
Show 11 quoted lines
>> @@ -1669,7 +1669,7 @@ static void compute_reachable_generation_numbers(
>> struct commit *current = list->item;
>> struct commit_list *parent;
>> int all_parents_computed = 1;
>> - uint32_t max_gen = 0;
>> + timestamp_t max_gen = 0;
>>
>> for (parent = current->parents; parent; parent = parent->next) {
>> repo_parse_commit(info->r, parent->item);
>
> This looks obviously correct.I agree. I was surprised this was the only necessary change, but your message clearly describes how the timing of the patch that delivered this change contributed to the mismatch.
Thanks, -Stolee