git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] [GSoC] userdiff: adding typescript pattern

From
Johannes Sixt <j6t@kdbg.org>
Date
Mar 29, 2026, 09:31 UTC
Message-ID
<08f1c2b1-5f2c-40e9-ba87-f45cae6af541@kdbg.org>
In-Reply-To
<pull.2251.git.git.1774734004.gitgitgadget@gmail.com>
Am 28.03.26 um 22:40 schrieb Dhruv Arora via GitGitGadget:
Show 29 quoted lines
> 
> Description
> ===========
> 
>  * Add builtin userdiff pattern for TypeScript files. Recognizes function
>    declarations, class definitions, arrow functions, and method definitions.
>    
>    * Handles common modifiers like export, async, static, etc
> 
>  * Added tests for the typescript pattern in userdiff.
> 
> Dhruv Arora (2):
>   userdiff: adding typescript pattern
>   fix(userdiff): sorted pattern and tests
> 
>  t/t4018/typescript-class-method         |  7 +++++++
>  t/t4018/typescript-export-default-class |  7 +++++++
>  t/t4018/typescript-export-function      |  7 +++++++
>  userdiff.c                              | 15 +++++++++++++++
>  4 files changed, 36 insertions(+)
>  create mode 100644 t/t4018/typescript-class-method
>  create mode 100644 t/t4018/typescript-export-default-class
>  create mode 100644 t/t4018/typescript-export-function
> 
> 
> base-commit: ce74208c2fa13943fffa58f168ac27a76d0eb789
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2251%2FDhruv-0-Arora%2Fuserdiff%2Ftypescript-pattern-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2251/Dhruv-0-Arora/userdiff/typescript-pattern-v1
> Pull-Request: https://github.com/git/git/pull/2251

Javascript and Typescript are related languages, if I am not mistaken. It would be appreciated if the new language driver could be used for both. Then the driver's name should be the superset language and the documentation (missing, BTW) should mention that the driver can be used for both languages.

We have had a number of submissions for Javascript or Typescript drivers in the past, but none of them were followed through to be integrated.

Typescript:

https://lore.kernel.org/git/20240404163827.5855-1-utsavp0213@gmail.com/ https://lore.kernel.org/git/pull.1746.git.git.1721061218993.gitgitgadget@gmail.com/

Javascript:

https://lore.kernel.org/git/20240301074048.188835-1-sergiusnyah@gmail.com/ https://lore.kernel.org/git/20220403132508.28196-1-a97410985new@gmail.com/ https://lore.kernel.org/git/20250604094100.80598-1-derick.william.moraes@gmail.com/

Please review these submission and the responses that they received. Perhaps you can find inspiration for improvement from them.

-- Hannes
Previous: Junio C HamanoNext: Ben Knoble
Message 5 of 6 in “[GSoC] userdiff: adding typescript pattern”
  1. 0/2 [GSoC] userdiff: adding typescript patternDhruv Arora via GitGitGadget, Mar 28, 2026
  2. 1/2 userdiff: adding typescript patternDhruv Arora via GitGitGadget, Mar 28, 2026
  3. 2/2 fix(userdiff): sorted pattern and testsDhruv Arora via GitGitGadget, Mar 28, 2026
  4. Junio C HamanoMar 29, 2026
  5. Johannes SixtMar 29, 2026
  6. Spelling JavaScript (was: Re: [PATCH 0/2] [GSoC] userdiff: adding typescript pattern)Ben Knoble, Mar 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.